Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute the matrix of an isogeny on a given n-torsion subgroup #35164

Merged
merged 4 commits into from
Mar 26, 2023
Merged

compute the matrix of an isogeny on a given n-torsion subgroup #35164

merged 4 commits into from
Mar 26, 2023

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 20, 2023

Fixes #34879.

@yyyyx4 yyyyx4 force-pushed the public/matrix_of_isogeny branch from b463e46 to 5019f6e Compare February 20, 2023 04:23
@yyyyx4 yyyyx4 requested a review from defeo February 20, 2023 04:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023 •
edited
Loading

Codecov Report

Base: 88.57% // Head: 88.58% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (58193bf) compared to base (52a81cb).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35164      +/-   ##
===========================================
+ Coverage    88.57%   88.58%   +0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397297      +24     
===========================================
+ Hits        351891   351955      +64     
+ Misses       45382    45342      -40
Impacted Files Coverage Δ
src/sage/schemes/elliptic_curves/hom.py 83.33% <83.33%> (ø)
src/sage/groups/affine_gps/euclidean_group.py 88.88% <0.00%> (-11.12%) ⬇️
src/sage/homology/matrix_utils.py 84.40% <0.00%> (-3.67%) ⬇️
src/sage/groups/affine_gps/affine_group.py 96.62% <0.00%> (-2.25%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/combinat/combination.py 93.50% <0.00%> (-1.50%) ⬇️
src/sage/cpython/_py2_random.py 75.20% <0.00%> (-1.24%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 51.42% <0.00%> (-0.72%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4 yyyyx4 force-pushed the public/matrix_of_isogeny branch from 5019f6e to 10aff66 Compare February 20, 2023 08:25
@yyyyx4 yyyyx4 requested a review from JohnCremona February 20, 2023 08:45
@JohnCremona
Copy link
Member

OK, I will review this

JohnCremona
JohnCremona suggested changes Feb 20, 2023
View reviewed changes
src/sage/schemes/elliptic_curves/hom.py Outdated Show resolved Hide resolved
src/sage/schemes/elliptic_curves/hom.py Outdated Show resolved Hide resolved
@yyyyx4 yyyyx4 removed the request for review from defeo February 21, 2023 10:08
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 58193bf

@vbraun vbraun merged commit dc4930a into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
@yyyyx4 yyyyx4 deleted the public/matrix_of_isogeny branch April 2, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCremona JohnCremona JohnCremona requested changes

Assignees
No one assigned
Labels
c: elliptic curves p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

compute matrix of isogeny on n-torsion
6 participants
@yyyyx4 @codecov-commenter @JohnCremona @vbraun @kwankyu @mkoeppe